[MEDIUM] security(android): prevent prefetch from blocking indefinitely - #1140
Open
OskarEichler wants to merge 1 commit into
Open
[MEDIUM] security(android): prevent prefetch from blocking indefinitely#1140OskarEichler wants to merge 1 commit into
OskarEichler wants to merge 1 commit into
Conversation
|
@OskarEichler is attempting to deploy a commit to the Nearform Team on Vercel. A member of the Team first needs to authorize it. |
🦋 Changeset detectedLatest commit: de49c49 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Security impact
Android prefetchConfiguration blocks its native module queue on CountDownLatch.await(). Several normal paths never decrement that latch: discovery errors, invalid explicit configuration, and a cached issuer reached while the global isPrefetched flag is still false. A failing or malformed OAuth discovery response can therefore leave the promise and RNAppAuth native queue blocked indefinitely, preventing later authentication work until process restart.
Fix
This PR is limited to the prefetch availability defect. Concurrent interactive state and stale custom headers are submitted separately.
Breaking / observable changes
Android callers should await or catch prefetchConfiguration: it now settles when native prefetch completes and rejects on discovery/configuration failure. iOS remains a no-op.
Verification
The repository has no Android native unit-test target; this focused native change is verified by the Android compilation and existing suites. Documentation, error-code typing, and a patch changeset are included. This supersedes only the prefetch portion of #1128.